Skip to content

Conversation

@dsweber2
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

grf somehow produces unsorted quantiles. This is a bit of a hack to fix that; it includes a test that hopefully covers the breaking cause. Also, epidatasets is missing, but the datasets have been removed. That is patched so the tests actually work.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dsweber2 dsweber2 requested a review from dajmcdon as a code owner October 24, 2024 16:42
@dsweber2 dsweber2 self-assigned this Oct 24, 2024
@dsweber2
Copy link
Contributor Author

Note that I accidentally pushed this to dev, but then reverted that, so the contents may show up twice in histories. Sorry about that.

@dajmcdon dajmcdon merged commit 2126db5 into dev Oct 24, 2024
2 checks passed
@dshemetov dshemetov deleted the fixingGrfQuantiles branch April 10, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants